search

microsoft / devhome

The new Dev Home experience for Windows!
https://aka.ms/devhomedocs
MIT License
3.56k stars 310 forks source link

[FE + Version Control] Accessibility Insights Fast Pass: Section 508 502.3.1: (DevHome/button '') The Name property must not contain any characters in the private Unicode range. #3665

Closed ethanfangg closed 6 days ago

ethanfangg commented 3 weeks ago

The following accessibility issue needs investigation.

App: DevHome

Element path: button ''

Issue Details: The Name property must not contain any characters in the private Unicode range. Section 508 502.3.1

How To Fix: Modify the Name property, removing all characters in the range U E000 to U F8FF and replace them with meaningful, standard text content.

This accessibility issue was found using Accessibility Insights for Windows, a tool that helps debug and find accessibility issues earlier. Get more information and download this tool at https://aka.ms/AccessibilityInsights.

DefaultRyan commented 3 weeks ago

@ethanfangg can you clarify (visual tree path or owning type) that tells us which button this is referring to?

ethanfangg commented 3 weeks ago

@DefaultRyan, @ssparach should know but let me also attach a screenshot of the Accessibility Insights tool analysis:

image

(I believe this has to do with the "Git" drop down)

ssparach commented 3 weeks ago

@DefaultRyan, @ssparach should know but let me also attach a screenshot of the Accessibility Insights tool analysis:

image

(I believe this has to do with the "Git" drop down)

Yes, this has to do with hardcoding the name of the extension on the dropdown i.e. Git

DefaultRyan commented 1 week ago

I just ran the Accessibility Insights again on Canary 0.1701.612.0, and it's still reporting improperly named Button. It's the "..." next to the Dropdown.

image