search

microsoft / devhome

The new Dev Home experience for Windows!
https://aka.ms/devhomedocs
MIT License
3.59k stars 316 forks source link

[Dev Home]Dev Home does not seem to make use of NavigationView's back button, making navigation around the app inconsistent #551

Open mathewleeza opened 1 year ago

mathewleeza commented 1 year ago

Dev Home version

No response

Windows build number

No response

Other software

No response

Steps to reproduce the bug

Description Contrast with other navigation views in Windows, like Settings. When you navigate into an area, you get a back button in the top left that replaces the hamburger button and can be used to get back to where you are.

If I go into Machine Configuration -> Clone repositories, I have to click "Cancel" to get back to where I was. There is no back stack being used.

Expected result

No response

Actual result

No response

Included System Information

No response

Included Extensions Information

No response

marcelwgn commented 1 year ago

Some of the work is already done for this, however some of the pages use an "inner" navigation, i.e. within a page you have multiple steps. Those steps sometimes do not happen in the root frame but rather an inner frame that might also needs to be taken into account.

This behavior can be currently also observed by navigating deeper into the "Machine configuration" page and then switching between any other navigation entry and the "Machine configuration" entry; the state of the "Machine configuration" tab is restored. If this behavior is not a blocking issue for the back button, I would gladly create a PR for this.

ianyyu commented 11 months ago

@krschau @EricJohnson327

Here is the Figma guidance for Global Back button

mathewleeza commented 11 months ago

Bug 44310341: [Dev Home]Dev Home does not seem to make use of NavigationView's back button, making navigation around the app inconsistent