search

microsoft / devicescript

TypeScript for Tiny IoT Devices (ESP32, RP2040, ...)
https://microsoft.github.io/devicescript/
MIT License
3.24k stars 113 forks source link

Implement es Map class #497 #538

Closed Bohemus307 closed 11 months ago

Bohemus307 commented 1 year ago

Added es Map class methods

Added es Map class interface

Added basic tests for the es Map class

This will be my first contribution to open source and I really appreciate any guidance or advice on contributions going forward. Thanks for your time and patience on this.

Bohemus307 commented 1 year ago

@microsoft-github-policy-service agree

mmoskal commented 12 months ago

Or you can wait until I figure out how export symbols from core but this may take quite some time...

Bohemus307 commented 12 months ago

I'm happy to give it a try! Stay tuned.

But that does answer some of my lingering questions on the codebase so thank you.

Bohemus307 commented 12 months ago

Ok I think i got it but excited to hear more!

Bohemus307 commented 11 months ago

I didnt think i changed anything with the jacdac submodules at all. I can revert changes if needed my apologies.

mmoskal commented 11 months ago

Don't worry about the submodules. I'll fix it if needed.

However, it seems you forgot some changes to runtime/index.ts ? see https://github.com/microsoft/devicescript/actions/runs/5523589721/jobs/10154461568?pr=538#step:9:869

Bohemus307 commented 11 months ago

yeah i definitely did. Im not sure how it passed my tests. Sorry again. Also I wanted to thank you for your patience on this one def a learning experience!