Implement es Set class #496

microsoft / devicescript

TypeScript for Tiny IoT Devices (ESP32, RP2040, ...)

https://microsoft.github.io/devicescript/

MIT License

3.24k stars 113 forks source link

Implement es Set class #496 #556

Closed KevinL10 closed 11 months ago

KevinL10 commented 12 months ago

Closes #496. One question: how should I make the size a readonly property instead of a method?

pelikhan commented 11 months ago

Right, we don't currently support properties. We could, for now, maintain an additional field with the length which we could refactor later on. Btw, for now, we are going to move runtime implementation to the runtime module, but we're happy to refactor your PR!

KevinL10 commented 11 months ago

@pelikhan thanks! moved the implementation to runtime and added the size field