search

microsoft / devkit-sdk

Arduino library and package for the MXChip IoT DevKit
https://aka.ms/devkit
MIT License
68 stars 57 forks source link

Client.h is missing from Arduino core #1067

Open prototypicalpro opened 4 years ago

prototypicalpro commented 4 years ago

Hello! It looks like the Arduino core is missing Client.h. This file contains the Client interface, which allows internet libraries such as EthernetClient and SSLClient to define a generic internet communication API. I'm not sure if this file was ommitted intentionally, but adding it to the Arduino core would prevent compilation errors when using these libraries (such as https://github.com/OPEnSLab-OSU/SSLClient/issues/11). Thanks!

prototypicalpro commented 4 years ago

In addition, it looks like the AZ3166WiFiClient inherits from Print despite implementing all the features that the Client interface requires. Client inherits from Print, so could AZ3166WiFiClient inherit from Client instead? This change would improve compatibility with libraries that need generic network interfaces such as PubSubClient.

github-actions[bot] commented 4 years ago

This issue has no recent activities, please take a look and provide updates for it.

prototypicalpro commented 3 years ago

This issue is still present, and a fix would be much appreciated.