search

microsoft / dicom-server

OSS Implementation of DICOMweb standard
MIT License
463 stars 173 forks source link

Wrong media type for Retrieve Instance transaction #444

Closed hackermd closed 3 years ago

hackermd commented 3 years ago

Describe the bug The Retrieve Instance transaction of the DICOMweb service uses the wrong media type. It should be multipart/related; type="application/dicom" instead of application/dicom. See DICOM Correction Proposal 2040 for clarification.

StevenBorg commented 3 years ago

Thank you, @hackermd ! That certainly simplifies the retrieve transactions and makes all of them consistent with each other. We're looking into this now, and it certainly makes sense. Thanks! We'll keep you posted here.

hackermd commented 3 years ago

Great! Thanks for looking into it @StevenBorg

StevenBorg commented 3 years ago

@hackermd After some discussion, our take is that we should adopt the newer framework, even prior to acceptance under the standard, while still maintaining backward compatibility (in this case) for APIs which might be using the current standard. Do you see any concerns with this approach?

hackermd commented 3 years ago

No concerns. I agree that this would be the best approach.

The "newer" framework has actually always been the standard - at least it was supposed to. The goal of Supplement 183 was to refactor the documentation of Part 18 without actually changing the behavior. Unfortunately, a few things got broken and we are currently trying to correct those. However, since Supplement 183 was officially accepted, we should probably consider application/dicom to be standard compliant or at least support it in a backwards compatible manner. We are going to do the same client-side (see https://github.com/MGHComputationalPathology/dicomweb-client/pull/43).

smithago commented 3 years ago

Issue is fixed. Closing