search

microsoft / do-client

Delivery Optimization client components
MIT License
24 stars 20 forks source link

Replace boost::filesystem usage with std::filesystem #166

Closed shishirb-MSFT closed 1 year ago

shishirb-MSFT commented 1 year ago

Always wanted to move to the C++17 filesystem implementation. What prompted the change now: The FindBoost issue on Ubuntu 20.04 involving symlinking /lib to /usr/lib but /include being non-existent. This change removes public dependency on Boost libs entirely, leaving only the tests using boost::program_options.

shishirb-MSFT commented 1 year ago

GCC on Ubuntu 18.04 does not have std::filesystem :(

Jerry-GeGarcia commented 1 year ago

No-go? Connected to our conversation earlier today regarding shift in approach?

From: shishirb-MSFT @.> Sent: Tuesday, March 21, 2023 9:58 PM To: microsoft/do-client @.> Cc: Jerry Garcia @.>; Review requested @.> Subject: Re: [microsoft/do-client] Replace boost::filesystem usage with std::filesystem (PR #166)

GCC on Ubuntu 18.04 does not have std::filesystem :(

- Reply to this email directly, view it on GitHubhttps://github.com/microsoft/do-client/pull/166#issuecomment-1478917836, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AM7PRTH72FAW3M7GMNL7K3TW5KBFNANCNFSM6AAAAAAWDKHGDI. You are receiving this because your review was requested.Message ID: @.**@.>>