search

microsoft / do-client

Delivery Optimization client components
MIT License
24 stars 20 forks source link

Use std::error_code with custom error category #95

Closed jimson-msft closed 3 years ago

shishirb-MSFT commented 3 years ago 
int32_t error_code() const;

IMO this is redundant since caller can get it from std::error_code. We should remove this and rename get_error_code() to error_code().

In reply to: 942778026

In reply to: 942778026

In reply to: 942778026

In reply to: 942778026

In reply to: 942778026

In reply to: 942778026

In reply to: 942778026

Refers to: sdk-cpp/include/do_errors.h:84 in efea6d9. [](commit_id = efea6d9ba08fe7ee387b2844d65a3b30abba7b6d, deletion_comment = False)

jimson-msft commented 3 years ago

So weird, there's some issues with github/CF - replying to a comment closed the PR. I'll look into submitting a ticket to CF team

In reply to: 943756987

In reply to: 943756987

jimson-msft commented 3 years ago

There are some failing tests with these changes, looking into fixing now

jimson-msft commented 3 years ago

There are some failing tests with these changes, looking into fixing now

Resolved