microsoft / dotnet-framework-docker

The repo for the official docker images for .NET Framework on Windows Server Core.
https://hub.docker.com/_/microsoft-dotnet-framework
MIT License
692 stars 332 forks source link

Suppress CodeQL alerts for generated code #1136

Closed mthalman closed 4 weeks ago

mthalman commented 1 month ago

Adds CodeQL suppressions for some issues that are being alerted upon from the aspnetapp sample. This code comes from the project template. I checked with the latest templates from Visual Studio and they have the same code as we have currently.

lbussell commented 1 month ago

Theoretically .NET Framework is getting these same alerts in its source code. Should we file a follow-up issue to remove this if that is ever fixed? It may also be unlikely to be fixed.

mthalman commented 1 month ago

Theoretically .NET Framework is getting these same alerts in its source code. Should we file a follow-up issue to remove this if that is ever fixed? It may also be unlikely to be fixed.

That would happen naturally whenever we update samples. We'd just copy over our existing files with the new content.