search

microsoft / dstoolkit-web

Repository for the Data Science Toolkit website
MIT License
8 stars 1 forks source link

Fix related accelerator links #108

Closed Jbetts05 closed 2 years ago

Jbetts05 commented 2 years ago

3 main changes needed: 1) In script-setsingleaaccleratorpagecontents.js, add /dstoolkit-web/ before each link so instead of /forecasting/ have /dstoolkit-web/forecasting/ 2) In each accelerator page, add /dstoolkit-web/ for the listLinksRelatedAccelerators const so instead of /ml-ops/ have /dstoolkit-web/ml-ops/ 3) update knowledge mining to use the Github Pages page and not the Github Repo for KM in setsingleaaccleratorpagecontents.js

strobaek commented 2 years ago

Hi, Do you have to prefix with 'dstoolkit-web'? Would it not be possible to prefix with 'site.baseurl'? To make it more generic?

Jbetts05 commented 2 years ago

@strobaek possibly yeah, does the displayName get updated when using {{site.baseurl}}? For the example of forecasting, is the button name still labelled with 'dstoolkit-web/forecasting' or does it change to 'Forecasting Accelerator'?

strobaek commented 2 years ago

@Jbetts05 Fixed it another way in the js-file, so we keep the accelerator pages simple. I'll assign you as reviewer soon :)

strobaek commented 2 years ago

@Jbetts05 Re. 3. Not quite sure what link. Variable linkAccessAcceleratorRepo should point to the GitHub repo (and not page). Is it the links in [].js for the Related Accelerators?

Jbetts05 commented 2 years ago

@strobaek just here: script-setsingleacceleratorpagecontents.js line 119. Should this be /knowledge-mining/?

image
strobaek commented 2 years ago

Fixed with another push. Guess I screwed up there.