search

microsoft / dtdl-model-generator

A library used for generating C# classes from DTDL interfaces.
MIT License
13 stars 16 forks source link

Contribute to generating Open DigitalTwins Building classes #10

Closed LaurentLapierre closed 2 years ago

LaurentLapierre commented 2 years ago

I would like to share my changes to allow your generator tool to parse the official Open DigitalTwins Building model (https://github.com/Azure/opendigitaltwins-building). Thanks for your open tool

ghost commented 2 years ago

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

:x: LaurentLapierre sign now
You have signed the CLA already but the status is still pending? Let us recheck it.

ms-mikeb commented 2 years ago

Hey @LaurentLapierre thank you very much for your contribution.

Ideally I think we'd like to refrain from checking in generated model sets, especially ones as large as the REC models.

If you could modify this to output the models to the bin folder as many other tests do that would be great.

Additionally, if there's unique behavior you feel would warrant having tests for on the generated models, then maybe use a subset of the REC models if possible that would exercise this specific behavior.

Please let me know if you have any thoughts or suggestions.

LaurentLapierre commented 2 years ago

Hello @ms-mikeb, I understand the decision to separate the code source and the use. I have done for my projects.

Please let me know if you want to a new pull request without REC models. There is at least one commit that may interest you - commit 57180061 -> "Fix bug of empty description or display for EnumPropEntity"