strictFunctionTypes isn't specified

mtsmfm commented 5 years ago

It seems https://github.com/Microsoft/dts-gen/pull/87 isn't applied to the latest release.

https://unpkg.com/dts-gen@0.5.7/bin/lib/definitely-typed.js

function getTSConfig(packageName) {
    return {
        compilerOptions: {
            module: "commonjs",
            lib: ["es6"],
            noImplicitAny: true,
            noImplicitThis: true,
            strictNullChecks: true,
            baseUrl: "../",
            typeRoots: ["../"],
            types: [],
            noEmit: true,
            forceConsistentCasingInFileNames: true,
        },
        files: [
            "index.d.ts",
            `${packageName}-tests.ts`,
        ],
    };
}

@RyanCavanaugh Can I ask you to cut new release?

weswigham commented 5 years ago

@andy-ms ?

oBusk commented 5 years ago

When generating brand new package, getting

Error: Expected `"strictFunctionTypes": true` or `"strictFunctionTypes": false`.
    at Object.<anonymous> (/Users/user/DefinitelyTyped/node_modules/dtslint/bin/checks.js:106:23)
    at Generator.next (<anonymous>)
    at fulfilled (/Users/user/DefinitelyTyped/node_modules/dtslint/bin/checks.js:4:58)

on first lint because dts-gen does not specify.

BendingBender commented 5 years ago

Yeah, it seems that the build wasn't run the last time the package was published.

microsoft / dts-gen

strictFunctionTypes isn't specified #119