search

microsoft / dts-gen

dts-gen creates starter TypeScript definition files for any module or library.
MIT License
2.43k stars 102 forks source link

Crash more gracefully when using --dt #57

Open DanielRosenwasser opened 7 years ago

DanielRosenwasser commented 7 years ago

While dts-gen shouldn't crash, it's just going to sometimes. That's fine, but DefinitelyTyped used to have a script that consistently worked. Now the instructions are to rely on dts-gen entirely, and having just tried it on a library (moonjs), it just crashed.

This package needs to have some sort of general graceful fallback behavior if DefinitelyTyped is going to rely on it. Otherwise we're making it way too annoying/difficult to contribute.

CC @andy-ms @RyanCavanaugh @mhegazy

mhegazy commented 7 years ago

Makes sense. If it failed it should at least create the file with the right header.