microsoft / dts-gen

dts-gen creates starter TypeScript definition files for any module or library.
MIT License
2.43k stars 102 forks source link

fix: use ret to check before modifying #64

Closed joscha closed 7 years ago

joscha commented 7 years ago

This is not a problem right now, as there are no other transformations on s, but if the code changes in the future and this is overlooked, it might cause problems.

Sorry about that.

follow-up to #63

msftclas commented 7 years ago

This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. We will now review your pull request. Thanks, Microsoft Pull Request Bot

RyanCavanaugh commented 7 years ago

Good catch