microsoft / dtslint

A utility built on TSLint for linting TypeScript declaration (.d.ts) files.
MIT License
925 stars 86 forks source link

When using dtslint for "testing" packaged typings it requires the package to be private #96

Closed silkentrance closed 6 years ago

silkentrance commented 6 years ago

In effect, this cannot be used stand alone and is meant for use with DefinitelyTyped only.

Error: .../package.json should set `"private": true`
    at Object.<anonymous> (.../bump-regex/node_modules/dtslint/bin/checks.js:22:19)

Please remove this rather arbitrary restriction in order to allow us to integrate required typings directly into our packages and enable to reuse this tool.

silkentrance commented 6 years ago

What about using a proper build/test chain, e.g. gulp + mocha/chai instead of your custom made and presumably always failing build/test related code?

silkentrance commented 6 years ago

But alas, this is even more involved as the checker will reject any unknown other properties of the package JSON. Removing that restricting, too, as it fails our requirements.