search

microsoft / durabletask-java

Java SDK for Durable Functions and the Durable Task Framework
MIT License
13 stars 7 forks source link

Implement suspend and resume client APIs #104

Closed kaibocai closed 1 year ago

kaibocai commented 1 year ago

Issue describing the changes in this PR

resolves #96

Pull request checklist

Additional information

Additional PR information

kaibocai commented 1 year ago

Integration tests passed on local on latest durabletask-sidecar. Added two integration tests, one is testing suspend instance, one is testing suspend and resume instance. Please let me know if they are sufficient. Thank you.

cgillum commented 1 year ago

@kaibocai great! So the next step for me is to update the sidecar container used by the CI. Can you also open an issue that tracks updating this documentation? https://learn.microsoft.com/en-us/azure/azure-functions/durable/durable-functions-instance-management?tabs=java#suspend-and-resume-instances-preview

kaibocai commented 1 year ago

Create issue https://github.com/microsoft/durabletask-java/issues/105 to track document update

kaibocai commented 1 year ago

Hi @cgillum , I have updated the unit tests (combine redundant tests and add one for testing termination). I found an issue in sidecar for method waitForInstanceCompletion, I raised a PR at https://github.com/microsoft/durabletask-sidecar/pull/19 can you take a look? Thank you.

kaibocai commented 1 year ago

Updated the sidecar, all tests pass. Merging this PR!

kanupriya15025 commented 1 year ago

@kaibocai @cgillum

  1. Can we also have a ticket to return the HTTP endpoints for suspend and resume in the HTTP Response we get after submitting an orchestrator?
  2. Also, the documentation is still not complete here : https://learn.microsoft.com/en-us/azure/azure-functions/durable/durable-functions-instance-management?tabs=java#suspend-and-resume-instances-preview