search

microsoft / durabletask-mssql

Microsoft SQL storage provider for Durable Functions and the Durable Task Framework
MIT License
87 stars 32 forks source link

Fix for #127 Is not properly using TaskHubName #128

Closed bhugot closed 1 year ago

bhugot commented 2 years ago

Fixed #127 Durability factory when calling for a client is using default TestHubName or DurableTaskOption HubName instead of using the specified TaskHub

bhugot commented 2 years ago

Hello @cgillum I reworked a bit the test so that we also use custom schema.

bhugot commented 1 year ago

Hello @cgillum any news on this?

bhugot commented 1 year ago

All good for me @cgillum

bhugot commented 1 year ago

@cgillum I fixed the test it was timeout due to purge but it's not required in multitenancy tests

cgillum commented 1 year ago

It looks like there might be a test concurrency issue now that we have multiple integration test classes . Here's the error from the CI:

Content root path: /home/runner/work/durabletask-mssql/durabletask-mssql/test/DurableTask.SqlServer.AzureFunctions.Tests/bin/Debug/net6.0/
  Failed DurableTask.SqlServer.AzureFunctions.Tests.WithoutMultiTenancyCoreScenarios.MultiInstanceQueries [1 ms]
  Error Message:
   System.Net.Sockets.SocketException : Address already in use

The solution mentioned here might be good to look into.

bhugot commented 1 year ago

Thx for the tips @cgillum was looking at it. could you rerun I hope attribute on CoreScenario is going to work with inheritance

bhugot commented 1 year ago

Great