Orchestration with a lot of activities call with Task.WhenAll take sometimes alot of time to be mark as completed

microsoft / durabletask-mssql

Microsoft SQL storage provider for Durable Functions and the Durable Task Framework

MIT License

87 stars 32 forks source link

Orchestration with a lot of activities call with Task.WhenAll take sometimes alot of time to be mark as completed #131

Closed bhugot closed 1 year ago

bhugot commented 1 year ago

Hello, Time to time we have some orchestration in the following state: Instance is Running Task is empty All Events related to the instance are completed and they are removed slowly from events according to the taskEventBatchSize and taskEventLockTimeout. Any idea how to fix this?

bhugot commented 1 year ago

Maybe it's related . Azure recommand to add CREATE NONCLUSTERED INDEX [nci_wi_NewEvents_0C4B0C7A9B472311807DF4F70A041684] ON [dt].[NewEvents] ([TaskHub], [VisibleTime]) WITH (ONLINE = ON)

cgillum commented 1 year ago

Can you provide more details about how to reproduce this problem? How many activities is your orchestration running in parallel?

bhugot commented 1 year ago

Hello can be 50K or more

bhugot commented 1 year ago

I think this could also be fixed by #134

cgillum commented 1 year ago

Okay, let's close this for now and check again once the v1.1.1 build is available.