search

microsoft / durabletask-mssql

Microsoft SQL storage provider for Durable Functions and the Durable Task Framework
MIT License
87 stars 32 forks source link

Synchronous reads for improved performance for large payloads #134

Closed bhugot closed 1 year ago

bhugot commented 1 year ago

…on because of mssql client async bug sqlcli

It should be easy to switch back when the fix is done It should also fix #126

bhugot commented 1 year ago

@cgillum a new version is coming as my fix was incorrect the performance issue what on the reader and not on ExecuteReaderAsync I let a first run to show the test performance (on my computer it was around 1 min 40 and after the fix it was 12sec)

cgillum commented 1 year ago

@bhugot I just verified your fix on my machine: your stress test takes 1.1 minutes without the fix and is 4.5 seconds with your fix. That's pretty incredible!

bhugot commented 1 year ago

:)

bhugot commented 1 year ago

It's ok for me