search

microsoft / durabletask-mssql

Microsoft SQL storage provider for Durable Functions and the Durable Task Framework
MIT License
87 stars 32 forks source link

Release of version 1.1.0 #135

Closed Kokenberg closed 1 year ago

Kokenberg commented 1 year ago

The documentation states that as of version 1.1.0 it should be possible to use 'Isolated shema mode', a mode I really would like to use.

image

However, the 1.1.0 NuGet package is nowhere to be found! I did see that all the code of the PR has been merged to main:

image

Would it be possible to release the 1.1.0 version?

jundayin commented 1 year ago

@Kokenberg As far as I can tell there are still two open issues for 1.1.0 milestone. One is under review and another still awaits for implementation. @cgillum Is it possible to triage the latter one to next milestone so that we can consume this version faster?

cgillum commented 1 year ago

Hi @jundayin and @Kokenberg. The only blocker at this point for v1.1.0 is the database upgrade testing PR, which unfortunately needs to be reworked a bit in order to be automated in GitHub Actions. However, we may not need to necessarily block the release on that. I've manually tested the upgrade scenario (going from v1.0.0 to v1.1.0) and I feel reasonably confident that automatically upgrading the database works correctly, even with in-flight orchestrations.

Just to help me feel confident about making the release, would either of you (or any other folks watching this issue) be willing to try out the v1.1.0-rc release that I just published this morning? If I can get confirmation that there are no issues with this upgrade, then that will give me the confidence to go ahead and publish a production-ready version of v1.1.0 this week.

Kokenberg commented 1 year ago

I'll gladly give the RC a try tomorrow (January 11th). I'll post my results.

Kokenberg commented 1 year ago

I just tested the 1.1.0-RC and I can confirm that that the 'Isolated schema' works. I only updated the NuGet package and started the Durable Task. In Azure Data Studio I saw the new schema with tables appear: image

cgillum commented 1 year ago

Thanks @Kokenberg!

@jundayin, do you have any availability to also try out the rc release bits?

Kokenberg commented 1 year ago

@cgillum I just saw you merged the PR for running in dotnet-isolated. Any chance that that PR can also end up in the 1.1.0 release? That is also a feature we have been waiting for.

cgillum commented 1 year ago

@Kokenberg unfortunately it turns the PR didn't work as intended (I merged it sooner than I should have). @jviau is going to help look into what additional fixes may be necessary, after which we can publish the new dotnet-isolated worker package.

We'll separately track support for .NET Isolated here: https://github.com/microsoft/durabletask-mssql/issues/106.

cgillum commented 1 year ago

The v1.1.0 release is complete: https://github.com/microsoft/durabletask-mssql/releases/tag/v1.1.0

jundayin commented 1 year ago

Hi, sorry. The notification was inundated by other emails.

I made a test and everything looks good. I created an orchestration 1.0.1 and re-start the program with update packages. The orchestration was picked up successfully and run without problem.

cgillum commented 1 year ago

Thanks for confirming @jundayin - much appreciated!