microsoft / durabletask-mssql

Microsoft SQL storage provider for Durable Functions and the Durable Task Framework
MIT License
87 stars 32 forks source link

Activity and sub-orchestration payload IDs are not saved in the history table #85

Closed cgillum closed 2 years ago

cgillum commented 2 years ago

When an orchestration schedules an activity or sub-orchestration, the input payload references are correctly saved to the NewEvents or NewTasks tables, but not to the History table. This makes debugging trickier because you can't know what the inputs for activities or sub-orchestrations are when looking at an orchestration's history.

The workaround is to set TaskHubWorker.TaskOrchestrationDispatcher.IncludeParameters to true. However, this API is not at all discoverable and is very poorly designed. At the time of writing, it also exposes a data duplication bug, tracked here: https://github.com/microsoft/durabletask-mssql/issues/84.

Ideally, by default, input payloads for activities and sub-orchestrations should be tracked in the history database.