search

microsoft / durabletask-python

A Durable Task Python SDK compatible with Dapr Workflow and its underlying Durable Task engine
MIT License
13 stars 6 forks source link

Include recursive flag in terminate_orchestration #27

Closed shivamkm07 closed 5 months ago

shivamkm07 commented 5 months ago

This PR adds recursive flag in terminate_orchestration to support cascade terminate which was added in DTF-Go: https://github.com/microsoft/durabletask-go/pull/47

It also updates protos for the same and adds test to verify recursive terminate behavior

shivamkm07 commented 5 months ago

LGTM. We don't currently run E2E tests as part of the CI. @shivamkm07, is this new test passing locally for you?

Yeah it is passing for me locally image

cgillum commented 5 months ago

@DeepanshuA can you work with @shivamkm07 to create a release of the Python SDK when necessary?

DeepanshuA commented 5 months ago

@DeepanshuA can you work with @shivamkm07 to create a release of the Python SDK when necessary?

Sure

DeepanshuA commented 5 months ago

@DeepanshuA can you work with @shivamkm07 to create a release of the Python SDK when necessary?

https://pypi.org/project/durabletask/0.1.1a1/ is now released. @cgillum Please merge https://github.com/microsoft/durabletask-python/pull/28 so that updated changelog gets available.