microsoft / ebpf-for-windows

eBPF implementation that runs on top of Windows
MIT License
2.92k stars 232 forks source link

Add decap_permit_packet.o in ebpf-for-windows.<version> msi #2642

Closed shpalani closed 1 year ago

shpalani commented 1 year ago

Describe the bug

ebpf-for-windows-demo project uses ebpf-for-windows as a nuget package. For Cilium L4LB test in ebpf-for-windows-demo requires decap_permit_packet.o to be added in ebpf-for-windows.<version>.msi, to help the user to avoid building ebpf-for-windows separately.

This request was brought in PR comment: https://github.com/microsoft/ebpf-for-windows-demo/pull/69

Requirement:

  1. Add decap_permit_packet.o to .msi
  2. Modify the cilium/load_balancer/docs/CiliumL4LBSetup.md in ebpf-for-windows-demo in Steps 3 - 4 in "Set Up Windows Backend Node(s)" section.

OS information

Windows 10 and above

Steps taken to reproduce bug

cilium/load_balancer/docs/CiliumL4LBSetup.md in https://github.com/microsoft/ebpf-for-windows-demo/

Expected behavior

Use decap_permit_packet.o from the .msi installation directory.

Actual outcome

The user has to manually build and copy the decap_permit_packet.o from the build machine to the test machine.

Additional details

No response

shpalani commented 1 year ago

Verified that the test files are present. Hence closing this issue.

https://github.com/microsoft/ebpf-for-windows/blob/main/docs/InstallEbpf.md#method-1-install-a-release-with-the-msi-installer

decap_permit_packet.o and all the testing files are already present when installed using ebpf-for-windows..msi.

When installing, please select 'Testing'

PS C:\Program Files\ebpf-for-windows\testing> dir decap*

    Directory: C:\Program Files\ebpf-for-windows\testing

Mode                 LastWriteTime         Length Name
----                 -------------         ------ ----
-a----         7/18/2023   7:58 PM          12384 decap_permit_packet.o
-a----         7/18/2023   7:59 PM          11600 decap_permit_packet.sys

PS C:\Program Files\ebpf-for-windows\testing>