search

microsoft / ebpf-for-windows

eBPF implementation that runs on top of Windows
MIT License
2.92k stars 229 forks source link

Self-host runner information should be provided as per-repository configuration data. #3347

Open dv-msft opened 7 months ago

dv-msft commented 7 months ago

Describe the bug

Currently the CI/CD pipeline used hard-coded self-hosted runner information (runner service names and the associated test runner vm names) as listed the the ebpf-for-windows\scripts\test_execution.json file.

This requires down-stream forks of ebpf-for-windows to use the same names in their own self-hosted runner setups. This information should really be ingested as a per-repository configuration data and the required test_execution.json file should be generated on-demand from this data.

(The <repo-name>\settings\environment facility can be used to store the per-repo self-host runner information in the current json format as a string. This string can then be converted to a test_execution.json file at the start of the CI/CD workflow).

OS information

No response

Steps taken to reproduce bug

  1. Create a self-hosted runner setup custom names for a down-stream fork <repo-name>\ebpf-for-windows.
  2. Try to run the CI/CD workflow on this setup.

Expected behavior

The workflow should use the custom runner setup to schedule CI/CD jobs.

Actual outcome

The Workflow fails as it cannot find the runners specified in the hard-coded self-hosted runner information.

Additional details

No response

gtrevi commented 7 months ago

Noting InstallEbpf.md should also be updated accordingly.