search

microsoft / ebpf-for-windows

eBPF implementation that runs on top of Windows
MIT License
2.92k stars 233 forks source link

bpf2c should support bpf2bpf function calls #3388

Open dthaler opened 7 months ago

dthaler commented 7 months ago

Describe the feature you'd like supported

currently bpf2c only supports inlined function calls, not bpf2bpf function calls. PREVAIL is adding support for non-inlined function calls, and bpf2c should do the same.

Proposed solution

Generate function calls when the bpf bytecode uses the call local instruction

Additional context

No response

shankarseal commented 7 months ago

The verifier changes are covered by https://github.com/vbpf/ebpf-verifier/pull/608 in the verifier repo. We need to make a similar change in bpf2c tool.

shankarseal commented 7 months ago

@dthaler are you OK with backlogging this? We will revisit this in the next week's triage.

dthaler commented 6 months ago

Blocked on https://github.com/vbpf/ebpf-verifier/pull/608 being merged

dthaler commented 4 days ago

Reactivating this for local stack variables which #3506 did not fix. That support is blocked on https://github.com/vbpf/ebpf-verifier/issues/720