search

microsoft / ebpf-for-windows

eBPF implementation that runs on top of Windows
MIT License
2.64k stars 206 forks source link

Multiple MSVC related fixes (#3623) #3632

Closed shankarseal closed 2 weeks ago

shankarseal commented 2 weeks ago

Cherry pick #3623.

dthaler commented 2 weeks ago

@shankarseal https://github.com/microsoft/ebpf-for-windows/blob/main/CONTRIBUTING.md#contributing-code says

For all new Pull Requests the following rules apply:

  • Existing tests should continue to pass.
  • Tests need to be provided for every bug/feature that is completed.
  • Documentation needs to be provided for every feature that is end-user visible.

Issue #3628 points out that the last bullet above is NOT met by this PR.

shankarseal commented 2 weeks ago

@shankarseal https://github.com/microsoft/ebpf-for-windows/blob/main/CONTRIBUTING.md#contributing-code says

For all new Pull Requests the following rules apply:

  • Existing tests should continue to pass.
  • Tests need to be provided for every bug/feature that is completed.
  • Documentation needs to be provided for every feature that is end-user visible.

Issue #3628 points out that the last bullet above is NOT met by this PR.

This will be addressed in main. Meanwhile I am going ahead with release/0.17.