search

microsoft / edge-selenium-tools

An updated EdgeDriver implementation for Selenium 3 with newly-added support for Microsoft Edge (Chromium).
https://developer.microsoft.com/en-us/microsoft-edge/tools/webdriver/
Apache License 2.0
88 stars 24 forks source link

Headless Mode #32

Closed Bamgm14 closed 3 years ago

Bamgm14 commented 3 years ago

Setting Headless mode without setting chromium to true is pointless Edit: Would like to mention I don't know the right way to approach a merge but I think adding one line should be fine.

bwalderman commented 3 years ago

Hi @Bamgm14, thank you for taking the time to make this pull request.

This is by design. Requiring users to set use_chromium makes it clear to others which version of the browser is being driven. One of our goals is also forward-compatibility with Selenium 4. Code written for Selenium 3 + Edge Selenium Tools should still work when migrated to Selenium 4. This change would mean that our EdgeOptions has a slightly different behavior than the official EdgeOptions in Selenium 4. Users upgrading to Selenium 4 might be surprised to find they now need to set use_chromium = True before headless mode and other Chromium-only options will work.

To ensure that Selenium Tools remains compatible with Selenium, we can't accept a change that affects behavior in this way. If you're still interested in making this change, I'd recommend opening an issue/PR in the official Selenium repo. In the future though, we hope to work with the Selenium maintainers to flip use_chromium to True by default so setting the flag will no longer be necessary to use Chromium.

Bamgm14 commented 3 years ago

Fair enough I am new to this so sorry if I did something wrong and thank you for explaining.

bwalderman commented 3 years ago

@Bamgm14, I will go ahead close this PR. Thanks again for reaching out!