search

microsoft / edge-selenium-tools

An updated EdgeDriver implementation for Selenium 3 with newly-added support for Microsoft Edge (Chromium).
https://developer.microsoft.com/en-us/microsoft-edge/tools/webdriver/
Apache License 2.0
88 stars 24 forks source link

Updated edge.js to properly support setting the page load strategy #47

Closed mastrzyz closed 2 years ago

mastrzyz commented 3 years ago

Currently if we set the pageLoadStrategy in JavaScript : 

    this.driverOptions.setPageLoadStrategy("none");

We get an error that this is not a valid ms:edge Option : 

    WebDriverError: invalid argument: cannot parse capability: ms:edgeOptions
    from invalid argument: unrecognized msedge option: pageLoadStrategy

Since this is a Chromium, I had to change the capability so it gets passed into as a chromium option like we do with logPrefs

rac2030 commented 2 years ago

Is this still considered to be merged in or abonded and pageLoadStrategy will only be available with selenium 4?

mastrzyz commented 2 years ago

Is this still considered to be merged in or abonded and pageLoadStrategy will only be available with selenium 4?

We migrated to Selenium 4 and it solved our problem but if people are still facing this issue, would be good to merge this in.

bwalderman commented 2 years ago

We're in the process of deprecating so there won't be any official releases with this change, but I'm merging this PR in case it is useful to anyone building the project from source. Thank you for your contribution!