microsoft / entra-verifiedid-wallet-library-ios

A library to manage your Decentralized Identities and Verified IDs on iOS.
MIT License
25 stars 11 forks source link

[Issuance V2] Pre-Auth Flow Complete #102

Closed symorton closed 2 months ago

symorton commented 2 months ago

Problem: Complete the Pre-Authorization flow for Issuance V2.

Solution: Complete the Pre-Authorization flow for Issuance V2.

Validation: Works as expected.

Type of change:

Risk:

Work Item links: Please include here links for this work item, or deferred work, or related work. E.g. if the refactoring is too big to fit in this PR, or the localized strings need to be updated later, please link the TODO work items here.

Documentation Links: Please include here links to any related background documentation for this PR.

mauesrog commented 2 months ago

Overall okay but have a few questions/suggestions, and am still confused on the expiry time parameter as its unclear if this is "expiry in seconds" relative to initiated at, or since epoch time.

@logangirvin it is not relative to epoch. think of it as time to live in seconds. this is why we called it expires in and not expires at.