search

microsoft / essex-toolkit

Provides a set of useful tools, utilities, reusable components, and React hooks that are designed to capture common components and utilities common among Essex Alpha team projects.
https://microsoft.github.io/essex-toolkit/
MIT License
19 stars 7 forks source link

GraphRagConfig in essex-config #277

Open andresmor-ms opened 1 month ago

andresmor-ms commented 1 month ago

This issue is to track and discuss if GraphRagConfig should be tested inside of essex-config python package instead of #276

AlonsoGuevara commented 1 month ago

Thanks for opening this issue. I consider having all of GraphRAG{s config in essex-config a bad approach. If we want to test functionally of the essex-config library we should focus on edge cases and proper coverage. Adding GraphRAG introduces a lot of objects, concepts and such that are irrelevant for the config library.

If what we want to test is that GraphRAG can work with essex-config it should be the other way arounf and we then migrate and test in the proper package. GraphRAG should be irrelevant or unknown to essex-config.