Adding support for NDIS Metadata blocks as comments in pcapng

microsoft / etl2pcapng

Utility that converts an .etl file containing a Windows network packet capture into .pcapng format.

MIT License

630 stars 114 forks source link

Adding support for NDIS Metadata blocks as comments in pcapng #19

Closed jp-stewart closed 4 years ago

jp-stewart commented 4 years ago

Adding support for NDIS Metadata blocks as comments in pcapng
Adjusting support for comments on EPB blocks to support above (Merging with recent PRs)
Clearing privacy bit being set by some 802.11 adapters
Correcting some comments, error messages, and variable types for consistency

Tested changes on two types of wlan adapters (nwifi & wdi) and on ethernet with two interfaces against wireshark version 3.2.0 for viewing pcapng files.

maolson-msft commented 4 years ago

Sorry for the review delay! I didn't originally get an email notification of this.

jp-stewart commented 4 years ago

Sorry for the review delay! I didn't originally get an email notification of this.

No worries. Thanks for the feedback. Will review And work on the requests.