search

microsoft / etl2pcapng

Utility that converts an .etl file containing a Windows network packet capture into .pcapng format.
MIT License
652 stars 114 forks source link

Fix TotalLength calculation bug that leads to corrupt blocks #34

Closed csujedihy closed 3 years ago

csujedihy commented 3 years ago

https://github.com/microsoft/etl2pcapng/commit/870232e9dbff6e053df350e0018009cd5a28d1ee introduced a bug where TotalLength in PcapNgWriteEnhancedPacket is incorrectly calculated which leads to corrupt blocks in pcap. Specifically, sizeof(option end) is added twice to TotalLength.