Adding RSS Hash Value to packet comments for vmswitch fragments

microsoft / etl2pcapng

Utility that converts an .etl file containing a Windows network packet capture into .pcapng format.

MIT License

652 stars 114 forks source link

Adding RSS Hash Value to packet comments for vmswitch fragments #55

Closed paul-rosswurm-1 closed 2 years ago

paul-rosswurm-1 commented 2 years ago

VMSwitch packet comment example with this change: PID=12312 VlanId=0 SrcPortId=1 SrcNicType=Internal SrcNicName=01234567-89AB-CDEF-0123-456789ABCDEF SrcPortName=0123456789ABCDE DstNicCount=1 HashValue=e12b2124

maolson-msft commented 2 years ago

It's too bad that the hash value is only available for vmswitch packets, because I don't really like revealing some info that's orthogonal to vmswitch in only the vmswitch packets. But it doesn't seem like a big enough issue to keep from making this change.

maolson-msft commented 2 years ago

Please increment VERSION to 1.8.0, and add a note to README.md about this feature add.