search

microsoft / etl2pcapng

Utility that converts an .etl file containing a Windows network packet capture into .pcapng format.
MIT License
607 stars 114 forks source link

released version should be dropped in zip format Etl2Pcapng.zip #61

Closed walter-1 closed 1 week ago

walter-1 commented 1 year ago

The Explorer plugin from James Kehr at https://github.com/microsoft/Convert-Etl2Pcapng expects to see a .zip file on the release server (https://github.com/microsoft/etl2pcapng/releases)

Can you please post the compressed Etl2Pcapng.zip there again? Thanks.

Reason: all engineers having installed the Explorer plugin are failing to convert ETL files to Wireshark pcap format after version 1.9.0 had been released.

maolson-msft commented 1 year ago

Thanks for the report Walter.

@JamesKehr I switched from the current zipfile-with-two-archs drop format to just dropping the 64-bit binary. How inconvenient is it for your wrapper to deal with this change?

JamesKehr commented 1 year ago

It won't be a problem. I just need to earmark a couple of hours to update the code.

maolson-msft commented 1 year ago

Good to hear! I'll leave this Issue open until then.

JamesKehr commented 1 year ago

@maolson-msft, the updated module has been published to the PowerShell Gallery. Version 2022-11-22 supports the new x64 binary download.

https://www.powershellgallery.com/packages/Convert-Etl2Pcapng/2022.11.22

https://github.com/microsoft/Convert-Etl2Pcapng

Please let me know if you run into any issues.

maolson-msft commented 1 year ago

@walter-1, how's it look?

walter-1 commented 1 year ago

Great! appreciate all combined efforts and agree resolving this issue. FYI: Update-Moduledid the trick for me to make the installed plug-in work again! Thanks James!

PS C:\TSSv2> Update-Module

Untrusted repository
You are installing the modules from an untrusted repository. If you trust this repository, change its InstallationPolicy value by running the Set-PSRepository cmdlet. Are you sure you want to install the modules from 'PSGallery'?
[Y] Yes  [A] Yes to All  [N] No  [L] No to All  [S] Suspend  [?] Help (default is "N"): A
dgcom commented 1 year ago

I would vote to keep zip file - many places have policy to prevent .exe download, but allow .zip files.

ViDou83 commented 1 year ago

It works for me as well, and what a surprise to see the speed of trace conversion! That will drop my coffee consumption for sure :)

nibanks commented 1 year ago

I propose the following instead of including the zip: https://github.com/microsoft/etl2pcapng/issues/63. This will make it very trivial to install on Windows: winget install etl2pcapng.

dgcom commented 1 year ago

Installing with package manager is not helping people, who cannot download executables from the web. Places which prohibit that won't allow unrestricted package managers either.