search

microsoft / etl2pcapng

Utility that converts an .etl file containing a Windows network packet capture into .pcapng format.
MIT License
607 stars 114 forks source link

Embed File Info and Version #65

Open nibanks opened 1 year ago

nibanks commented 1 year ago
image
maolson-msft commented 1 year ago

This PR adds an obscure rc file and moves a point of maintenance (the value of VERSION) to a harder-to-notice place. What do we get in return?

nibanks commented 1 year ago

This PR adds an obscure rc file and moves a point of maintenance (the value of VERSION) to a harder-to-notice place. What do we get in return?

The exe has the file info for version, description and copyright.

maolson-msft commented 1 year ago

Sure, but why is that more useful than simply printing the version? Is it required by the proposed package manager work?

nibanks commented 1 year ago

I don't think anything requires it, but the file info is a nice to have feature IMO.