search

microsoft / fabrikate

Making GitOps with Kubernetes easier one component at a time
MIT License
38 stars 5 forks source link

fab add --method local adds branch argument #229

Closed jomalsan closed 5 years ago

jomalsan commented 5 years ago

Describe the bug: This is not a breaking bug, however is a bit confusing. When I add a subcomponent that points to a local directory (using "--method local") the created subcomponent contains an argument for "branch: master"

Also, a list of the accepted arguments for --method in the docs for the command would be helpful. I believe that any argument will get passed from the command line to the component.yaml, however a list of the "special" arguments would be great.

To Reproduce: Command:

fab add demo-service --source demo-service --type component --method local

Added Subcomponent:

- name: demo-service
  type: component
  source: demo-service
  method: local
  branch: master

Expected behavior: When "--method local" is provided I would not expect "branch: master" to be included in the subcomponent definition. This is not a breaking change, however is a bit confusing when looking at component.yaml.

Screenshots:

Additional context: I am running fabrikate version 0.13.1

Desktop (please complete the following information):

Additional context