microsoft / fabrikate

Making GitOps with Kubernetes easier one component at a time
MIT License
38 stars 5 forks source link

All logging is written to STDERR #251

Closed basvandenbrink closed 5 years ago

basvandenbrink commented 5 years ago

Describe the bug: Fabrikate writes all output to STDERR.

To Reproduce: Execute any fabrikate command.

Expected behavior: Only errors are written to STDERR, all other messages should go to STDOUT.

Desktop:

evanlouie commented 5 years ago

Hi @basvandenbrink, thanks for catching this. This is caused from us using some of the default settings of logrus for logging which, by default, outputs all logs to stderr.

Sadly the library does not support switching between stdout and stderr for specific log levels within the library itself (only allows you to set a single output for all levels); and as you can see from the issue and PR below, the core maintainer has not been open to implementing or accepting any PRs to fix this.

https://github.com/sirupsen/logrus/issues/403 https://github.com/sirupsen/logrus/pull/671

I'll take some steps to resolve this on Fabrikates end this week:

basvandenbrink commented 5 years ago

@evanlouie Thanks for the quick head-up! Good to hear it is picked up.