microsoft / fabrikate

Making GitOps with Kubernetes easier one component at a time
MIT License
37 stars 5 forks source link

Getting Started guide does not work #285

Open BertelBB opened 4 years ago

BertelBB commented 4 years ago

Describe the bug: If you follow the instructions in the Getting Started section, then the resulting generated files are not compatible with Flux. This is because when you run the command to add simple-service, you are actually referencing the fabrikate-istio definition. The cloud-native definition also references fabrikate-istio as a subcomponent, as is stated in the guide. This is a problem for Flux because now you have duplicate YAML files for istio. See screenshot below.

To Reproduce: Run the fab commands from the guide in your cluster directory.

fab add cloud-native --source https://github.com/microsoft/fabrikate-definitions --path definitions/fabrikate-cloud-native
fab add simple-service --source https://github.com/microsoft/fabrikate-definitions --path definitions/fabrikate-istio

Create the config/prod.yaml file as stated in the guide. Run: fab install fab generate prod

Expected behavior: I expect the generated files for simple-service to include YAML files describing that service but not istio.
I guess the YAML files existed at some point in the fabrikate-definitions repo, but were moved and the Getting Started guide was not updated to reflect those changes.

Screenshots: image

Additional context: I am going through the Bedrock tutorial and creating a High Level Fabrikate description is part two of that tutorial. I am new to all of this, but as I understand it the generated files from Fabrikate are the files that should be added to the manifest repository, which Flux monitors for changes. Please correct me if I am wrong about this part.

Desktop (please complete the following information):

atrakic commented 3 years ago

In addition to above, during fab installstep I get:

INFO[22-12-2020 13:11:08] 🚁  Updating helm chart's dependencies for chart in '/home/admir/Projects/Azure/my-fabrikate/mycluster/components/simple-service/definitions/elasticsearch-logstash-kibana/helm_repos/logstash/stable/logstash' 
Error: exit status 1: Error: repo "https://kubernetes-charts.storage.googleapis.com/" is no longer available; try "https://charts.helm.sh/stable" instead

Usage:
  fab install [flags]

Flags:
  -h, --help   help for install

Global Flags:
  -v, --verbose   Use verbose output logs

$ fab version
INFO[22-12-2020 13:16:07] fab version 1.0.0-alpha1