microsoft / fabrikate

Making GitOps with Kubernetes easier one component at a time
MIT License
37 stars 5 forks source link

added daily builds at midnight #298

Closed michaelperel closed 4 years ago

michaelperel commented 4 years ago
michaelperel commented 4 years ago

@evanlouie @timfpark I opened this PR because when I started contributing on the helm 3 PR, tests were failing on master despite the badge in the README showing they passed. It was difficult at first to contribute because I thought I had done something wrong when setting up the project.

In that PR, I fix the logic of the broken tests as part of the helm 3 upgrade.

In this PR, I suggest adding a nightly build so these problems can be caught/it becomes easier for people to contribute.

This means that this PR will fail, since master is failing. I figure this could be merged once the helm 3 PR is merged.

Thanks!

evanlouie commented 4 years ago

thanks for the PR! any reason you can think of we shouldn't merge now?

michaelperel commented 4 years ago

@evanlouie I think it should be merged, I just wasn't sure if it would be possible given that the build is failing. If you are able to, I am all for it!