search

microsoft / fabrikate

Making GitOps with Kubernetes easier one component at a time
MIT License
38 stars 5 forks source link

Use tags in a component version #305

Open fernandohackbart opened 4 years ago

fernandohackbart commented 4 years ago

In the component object model the attribute version supports a commit hash, would be useful to use a commit hash or a tag (pointing to a commit).

andrebriggs commented 4 years ago

@evanlouie I thought we do support this? I see it the fab add command here

$ fab add --source [--type <component|helm|static>] [--method <git|helm|local|http>] [--path ] [--version <SHA|tag|helm_chart_version>]

Documentation oversight? If not please assign to me

evanlouie commented 4 years ago

I'm somewhat against adding additional functionality to have moving targets be the target for components (I already don't like allowing people to just point to master or a branch) -- i've seen a lot of people shoot themselves in the foot in terms of production readiness by them pointing to a moving target in their components.

I'll think through this one a bit more, but in the in-term, it do think it would be good to add a tag field to specify the semantics of the SHA (i.e. its only a decoration for what the SHA represents).