Remove dependencies of unmaintained forks:

microsoft / fabrikate

Making GitOps with Kubernetes easier one component at a time

MIT License

38 stars 5 forks source link

Remove dependencies of unmaintained forks: #317

Open evanlouie opened 4 years ago

evanlouie commented 4 years ago

github.com/timfpark/conjungo
- github.com/imdario/mergo should work
github.com/timfpark/yaml
- gopkg.in/yaml.v3 should work
Write tests based on existing packages and ensure still pass after swap out

andrewDoing commented 4 years ago

After some investigation, neither of the proposed libraries can replace the same functionality without modification.

mergo: The mergo.Merge function can't replace conjungo.Merge because the current config gets overwritten in case of a conflict. Edit: The use of a transform function that avoids overwriting zero-value booleans could be developed.

gopkg.in/yaml.v2: The defaultMapType is hardcoded and cannot be overwritten, which appears to be the purpose of forking the repo.