search

microsoft / farmbeatsforstudents

MIT License
19 stars 15 forks source link

Script fails if the zip package is not installed #3

Closed gnolanccgs closed 2 years ago

gnolanccgs commented 3 years ago

Running this on a clean install of Raspberry Pi OS (Buster) fails near the end of the installation process because zip isn't installed by default and the error message for this is not repeated at the end of the installation process making it slightly confusing that the expected output image file is missing. If the script could include a contingency to install missing dependencies this would be helpful.

damyka commented 3 years ago

Thank you @gnolanccgs for pointing this out. I will make a note in the readme and will look into adding this to the bash script.

gnolanccgs commented 3 years ago

Thank you for this @damyka! Other than this minor issue I'm pleased to report that the script does a fantastic job.

damyka commented 2 years ago

@gnolanccgs, I have updated the readme and added a check/install for the missing dependency.

Thanks again for the feedback!

gnolanccgs commented 2 years ago

@damyka, thank you very much for fixing this issue. I'm glad to be of some assistance. Closing this as there doesn't appear to be any further action required. All the best!