search

microsoft / fast

The adaptive interface system for modern web experiences.
https://www.fast.design
Other
9.27k stars 593 forks source link

Ensure WCAG2.1 AA compliance as part of adding fast.design to repo #2315

Closed awentzel closed 2 years ago

awentzel commented 5 years ago

Describe the bug; what happened? See the validation errors produced by Accessibility Insights Edge (Chromium) browser extension.

image

What are the steps to reproduce the issue?

  1. Launch fast.design home page
  2. Click on the Accessibility Insights toolbar icon to scan the page
  3. See the results. Also attached.

What behavior did you expect? No errors

If applicable, provide screenshots:

In what environment did you see the issue?

Is there any additional context? no

chrisdholt commented 5 years ago

This will be taken care of as part of the migration to this repo. For now, I'm renaming and updating this to be a task.

stale[bot] commented 4 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

awentzel commented 4 years ago

Latest FastPass results attached. These results can be replicated by running "Accessibility Insights for the Web" Anaheim extension on https://www.fast.design

Accessibility Insights for Web automated checks result.pdf

chrisdholt commented 4 years ago

I think most of the above are fixed; I'll run it later this evening locally if I can to confirm - but we can also run after tomorrow's scheduled deployment.

awentzel commented 4 years ago

I gave it a run. Two issues remain. If you have Screen Shot 2020-08-13 at 7 22 36 AM

if you have the "Accessibility insights for web", then this link may also work extension://ghbhpcookfemncgoinjblecnilppimih/DetailsView/detailsView.html?tabId=589

awentzel commented 4 years ago

I did a Fast Pass w/ Accessibility Insights (extension) to see how we're looking and found two new issues. extension://ghbhpcookfemncgoinjblecnilppimih/DetailsView/detailsView.html?tabId=432

@chrisdholt will these be completed for Thursday or should we punt one release?

chrisdholt commented 4 years ago

I can’t see these with the link above, but @khamudom is working on the results of my pass on Sunday before I headed out of town. If it’s done for release, great - if not, I don’t see it as a blocker. Worst case, so long as nothing unpublished on npm is added after this release, we can always release as needed.

awentzel commented 4 years ago

Pushing to next release

EisenbergEffect commented 4 years ago

Should we push this out again?

chrisdholt commented 4 years ago

@eisenbergeffect let's pull this from releases for now. The only outstanding issues for the homepage is color contrast issues which could be related to our recipes. This is an ongoing thing we'll need to be tracking and working on, I think it's a bit of churn to link it to a specific release as we continue to work and drive ahead on it. Not to mention, the docusaurus pages are contributing to overall errors across the fast.design namespace and we technically can't fix those. I'm fine with keeping this open, but it would be great to not link it directly to a given release right now.

stale[bot] commented 3 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.