As described in https://github.com/microsoft/fast/issues/6311 picker's "filter-selected" and "filter-query" attributes were incorrectly configured and always ended up being true unless set via the prop.
This change resolves this issue by:
remove "filter-query" and "filter-selected" attributes (never worked)
introduces new disableQueryFilter and disableSelectionFilter props and associated attributes, defaults to false to match current default behavior
deprecates the filterQuery and filterSelected props but keeps them in sync with the new props so we shouldn't break anyone who is setting these
This change also fixes an issue where the "no options available" display wasn't always showing up:
When initialized with no options picker could open the menu without displaying the "no options available" message. This pr simplifies the mechanism that shows that to ensure it shows up when needed.
Pull Request
š Description
As described in https://github.com/microsoft/fast/issues/6311 picker's "filter-selected" and "filter-query" attributes were incorrectly configured and always ended up being true unless set via the prop.
This change resolves this issue by:
disableQueryFilteranddisableSelectionFilterprops and associated attributes, defaults to false to match current default behaviorfilterQueryandfilterSelectedprops but keeps them in sync with the new props so we shouldn't break anyone who is setting theseThis change also fixes an issue where the "no options available" display wasn't always showing up:
When initialized with no options picker could open the menu without displaying the "no options available" message. This pr simplifies the mechanism that shows that to ensure it shows up when needed.
š« Issues
closes https://github.com/microsoft/fast/issues/6311
ā Checklist
General
$ yarn changeComponent-specific