This PR fixes a bug where array observer would notify a splice when the mutation that occurred did not alter the array values. It appears in FE2 migration, an attempt to optimize for single-splice processing short-cut the projection process, which would detect non-mutation scenarios like splicing an array with the same values.
This issue has significant impact of the repeat directive, causing it to disconnect and re-connect views un-necessarily.
🎫 Issues
fixes ##6431
👩💻 Reviewer Notes
📑 Test Plan
✅ Checklist
General
[ ] I have included a change request file using $ yarn change
[ ] I have added tests for my changes.
[ ] I have tested my changes.
[ ] I have updated the project documentation to reflect my changes.
[ ] I have read the CONTRIBUTING documentation and followed the standards for this project.
Pull Request
📖 Description
This PR fixes a bug where array observer would notify a splice when the mutation that occurred did not alter the array values. It appears in FE2 migration, an attempt to optimize for single-splice processing short-cut the projection process, which would detect non-mutation scenarios like splicing an array with the same values.
This issue has significant impact of the
repeatdirective, causing it to disconnect and re-connect views un-necessarily.🎫 Issues
fixes ##6431
👩💻 Reviewer Notes
📑 Test Plan
✅ Checklist
General
$ yarn changeComponent-specific
⏭ Next Steps