Closed nicholasrice closed 1 year ago
Probably needs some more tests for the other volatile scenarios.
@EisenbergEffect Yeah good call, added tests for the other conditions.
I did notice there is a test for &&
- is that necessary? won't that always access both sides of the operator?
Pull Request
📖 Description
This PR adds detection for JavaScript's Optional chaining syntax to
Observable.isVolatile()
. Prior to this change, expressions that leveraged JavaScript optional chaining would not get detected as volatile, causing bindings to not update appropriately.🎫 Issues
👩💻 Reviewer Notes
📑 Test Plan
✅ Checklist
General
$ yarn change
Component-specific
⏭ Next Steps