microsoft / fast

The adaptive interface system for modern web experiences.
https://www.fast.design
Other
9.28k stars 595 forks source link

fix: Adds support for JavaScript optional chaining syntax in bindings #6788

Closed nicholasrice closed 1 year ago

nicholasrice commented 1 year ago

Pull Request

📖 Description

This PR adds detection for JavaScript's Optional chaining syntax to Observable.isVolatile(). Prior to this change, expressions that leveraged JavaScript optional chaining would not get detected as volatile, causing bindings to not update appropriately.

🎫 Issues

👩‍💻 Reviewer Notes

📑 Test Plan

✅ Checklist

General

Component-specific

⏭ Next Steps

nicholasrice commented 1 year ago

Probably needs some more tests for the other volatile scenarios.

@EisenbergEffect Yeah good call, added tests for the other conditions.

I did notice there is a test for && - is that necessary? won't that always access both sides of the operator?