m-akinc commented 1 year ago

Pull Request

📖 Description

There is a bug in the tabs component where you can use the keyboard (arrows, home/end) to navigate to a hidden tab. None of the tabs will appear as active, but the tab panel for the hidden tab will be displayed.

🎫 Issues

NA

👩‍💻 Reviewer Notes

📑 Test Plan

There is a TODO in the tabs test file for creating tests for keyboard navigation. I have created just two tests to exercise the use cases I fixed.

✅ Checklist

General

[x] I have included a change request file using $ yarn change
[x] I have added tests for my changes.
[x] I have tested my changes.
[ ] I have updated the project documentation to reflect my changes.
[x] I have read the CONTRIBUTING documentation and followed the standards for this project.

Component-specific

[ ] I have added a new component
[x] I have modified an existing component
[ ] I have updated the definition file
[ ] I have updated the configuration file

⏭ Next Steps

I would like this change cherry-picked into the archives/fast-element-1 branch.

chrisdholt commented 1 year ago

Thanks for this and including tests!

m-akinc commented 1 year ago

@chrisdholt What do I need to do to get this and another related fix (https://github.com/microsoft/fast/commit/84726aa1312068d10df176709d760764d577420f) cherry-picked into archives/fast-element-1? Do I just cherry-pick them into my fork's archives/fast-element-1 and then open a pull request? Or does one of the maintainers have to cherry-pick them directly?