microsoft / fast

The adaptive interface system for modern web experiences.
https://www.fast.design
Other
9.25k stars 590 forks source link

Foundation: Update Number field, Search, Switch, Text area, and Text field #6798

Closed bheston closed 6 months ago

bheston commented 1 year ago

Pull Request

đź“– Description

As part of the next major release of fast-foundation, we wanted to do a complete review of the component templates and align the structure and naming as much as possible.

This PR is split from https://github.com/microsoft/fast/pull/6286 and standardizes Number field, Search, Switch, Text area, and Text field.

Before on the left, update on the right. "C" = class, "P" = part, "R" = role, "S" = slot. đź’” = potentially style-breaking.

Number field

Number field

Search

Search

Switch

Switch

Text area

Text area

Text field

Text field

👩‍💻 Reviewer Notes

Review the Storybook site, or the illustrations of the components before and after, compared to the changes in code.

đź“‘ Test Plan

Tested via comparison against proposal and in Storybook.

âś… Checklist

General

Component-specific

scomea commented 1 year ago

Text/Number/Search field inputs don't track width of parent component in samples -

image

bheston commented 6 months ago

I tested the width issue in Storybook by manually adding width: 500px to each host element and found no issues. Hopefully that was the problem, either way there shouldn't be an issue with the underlying components, potentially only the local Storybook sample styling.