feat: picker max suggestions

scomea commented 1 year ago

📖 Description

While building a picker based ui with larger collections of suggestions I found that I needed to truncate the number of suggestions rendered in the UI "as you type". Makes sense for picker to enables this internally. This change adds a "max-suggestions" attribute to picker as well as showing a "type for more" message when large suggestion sets are truncated.

Also fixed an issue where max selection could be exceeded programmatically.

🎫 Issues

ad hoc

✅ Checklist

General

[x] I have included a change request file using $ yarn change
[ ] I have added tests for my changes.
[x] I have tested my changes.
[] I have updated the project documentation to reflect my changes.
[x] I have read the CONTRIBUTING documentation and followed the standards for this project.

Component-specific

[ ] I have added a new component
[x] I have modified an existing component
[ ] I have updated the definition file
[ ] I have updated the configuration file

janechu commented 4 months ago

@scomea circling back to this, is it still needed?

janechu commented 4 months ago

I'm going to close this as we are avoiding features while we reconcile open PRs with #6951.

microsoft / fast