microsoft / fast

The adaptive interface system for modern web experiences.

https://www.fast.design

Other

9.25k stars 590 forks source link

feat: enable stringification of DOM nodes controlled by FAST's renderer #6823

Open nicholasrice opened 1 year ago

nicholasrice commented 1 year ago

Pull Request

📖 Description

Enable JSON.stringy() for fast-controlled DOM nodes. This PR implements #6485 for fast v1.

🎫 Issues

fixes #6812

👩‍💻 Reviewer Notes

📑 Test Plan

✅ Checklist

General

[ ] I have included a change request file using $ yarn change
[ ] I have added tests for my changes.
[ ] I have tested my changes.
[ ] I have updated the project documentation to reflect my changes.
[ ] I have read the CONTRIBUTING documentation and followed the standards for this project.

Component-specific

[ ] I have added a new component
[ ] I have modified an existing component
[ ] I have updated the definition file
[ ] I have updated the configuration file

⏭ Next Steps

janechu commented 1 week ago

Looks like we need to add a change file, can you run yarn change to generate one?